https://bugzilla.redhat.com/show_bug.cgi?id=1301143 --- Comment #6 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- Wondering if it would be better to create github repository (e.g. fedora/golang-reviews) and instead of posting links to spec to post links to pull request and comment in the PR. Missing feature to comment lines of the spec file. Well, the devel subpackage is usefull for analysis. When the devel subpackage is present, it can be scanned for dependencies and other info about the code. At the moment we are running simple scans of new builds of golang projects in Koji. In future, we plan to report missing or broken dependencies. So if you provide the devel subpackage, you get automatic scans and reports about health of your package. Second, I would recommend to add some macro at the top of the spec. E.g. commit, provider_prefix, import_path. They are used for automatic updates of spec file (e.g. 'gofed bump') and in analysis (as described above). Third, you are using 'go build' inside Makefile. So your project can be built on architectures with golang compiler only. If you move the commands into %build section, you can use %gobuild macro a gain support for debugingo and architectures with gcc-go compiler. You can play with gofed for a while, try to run: # yum install gofed $ gofed repo2spec --detect github.com/runcom/skopeo --with-build --with-extra Bad news is it depends on docker so the devel subpackage will not be complete. The good new is you can build the project from bundled dependencies. Lokesh, we should definitely do something about the docker. This is another project that depends on it. If this is happening we should at least partially built the package from bundled and partially from debundled deps. At this point this is out of the question as we are still missing automatic tools that would do all the hard work for us. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review