https://bugzilla.redhat.com/show_bug.cgi?id=1302003 --- Comment #11 from Christos Triantafyllidis <christos.triantafyllidis@xxxxxxxxx> --- (In reply to gil cattaneo from comment #10) > (In reply to Christos Triantafyllidis from comment #9) > > > The following are not blocking the review: > > [!]: Latest version is packaged. > > This is intended to be a compat package thus the latest 2.x version is > > packaged. > > [!]: %check is present and all tests pass. > > Clarified in the comment in the spec and confirmed that the original package > > doesn't include %check too > > > > The following need to be addressed: > > [?]: Package contains no bundled libraries without FPC exception. > > While I don't see anything bundled, I see the following explicit provides: > > - bundle(apache-commons-codec) > > - bundle(jcip-annotations) > > - bundle(postgresql-jdbc) > > Those files are modifications of code included in: > apache-commons-codec src/main/com/mongodb/util/Base64Codec.java > jcip-annotations src/main/org/bson/util/annotations/* > postgresql-jdbc src/main/org/bson/io/UTF8Encoding.java > Now, is no more required ask an FPC exception if in the > spec file are explained the bundles libraries > I missed that change in the guidelines. Confirmed! > > [?]: Final provides and requires are sane (see attachments). > > Again the same provides as above, why are those explicitly defined? I don't > > see the original package to provide those. > what packages? I was referring to the current mongo-java-driver. Looks like that was a miss on the original package. > > [?]: Package functions as described. > > I'm not sure how to test this. Would it be possible to provide a test case? > > I'd like to run a simple test run especially given the fact that %check is > > not included. > maven build style not use and do not need the %check section I understand that this may not be used but I have no way to ensure that this package actually does what it is supposed to do. Is there a simple unit test I can use to cross-check it? If that requires mongo servers etc that is something that I cannot test. > > [!]: If package contains pom.xml files install it (including metadata) even > > when building with ant > already installed using %mvn_install instruction Agreed! > > [!]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mongo- > > java-driver2-javadoc > > No needed is a noarch package Not sure how the build arch relates to that. That more or less means that whenever the mongo-java-driver2-javadoc it should pull mongo-java-driver2 too. > > > > I also see that compared to the original package the following subpackages > > are missing: > > mongo-java-driver2-bson > > mongo-java-driver2-bson-javadoc > not needed Does this package provide also the bson package functionality? If not then it won't be a 100% compat package. Excuse the fact that I have minimal java knowledge, does that mean that no-one would ever need those bson subpackages? > > Also another thing that is not clear to me is why the SPEC file of > > mongo-java-driver is not used as a base for this given that the aim of a > > compat package should be to have the exactly the same functionality as the > > initial one that got updated. > > It is not necessary Yes but it would just make the SPEC preperation and the review much easier :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review