[Bug 1208911] New: Review Request: doublecmd-qt - Twin-panel (commander-style) file manager (Qt4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1208911

            Bug ID: 1208911
           Summary: Review Request: doublecmd-qt - Twin-panel
                    (commander-style) file manager (Qt4)
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody@xxxxxxxxxxxxxxxxx
          Reporter: projects.rg@xxxxxxxx
        QA Contact: extras-qa@xxxxxxxxxxxxxxxxx
                CC: extras-qa@xxxxxxxxxxxxxxxxx, i@xxxxxxxx,
                    package-review@xxxxxxxxxxxxxxxxxxxxxxx,
                    pahan@xxxxxxxxxxxxx, projects.rg@xxxxxxxx
        Depends On: 989791



Spec URL:
https://raphgro.fedorapeople.org/review/qt/doublecmd-qt/doublecmd-qt.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/qt/doublecmd-qt/doublecmd-qt-0.6.1-1.20150402svn5941.fc21.src.rpm
Description: Twin-panel (commander-style) file manager (Qt4)
Fedora Account System Username: raphgro

rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408616
==> ERROR: Broken dependency: KASComp 1.8>KASComp 1.8

f22 scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408636
==> OK

As a base doublecmd-gtk.spec from vondruch is used cause the links in the
original request (bug #989791) are dead.

There are some rpmlint errors about the plugin binaries. Not sure how to fix,
help would be very appreciated.


+++ This bug was initially created as a clone of Bug #989791 +++

Spec URL: http://cicku.me/doublecmd-qt4.spec
SRPM URL: http://cicku.me/doublecmd-qt4-0.5.6-1.fc20.src.rpm
Description: Double Commander is a cross platform open source file manager with
two panels 
side by side. It is inspired by Total Commander and features some new ideas.

Here are some key features of Double Commander:
- Unicode support
- All operations working in background
- Multi-rename tool
- Tabbed interface
- Custom columns
- Internal text editor (F4)  with syntax hightlighting
- Built in file viewer (F3) to view files of in hex, binary or text format
- Archives are handled like subdirectories. You can easily copy files to and 
from archives. Supported archive types: ZIP, TAR GZ, TGZ, LZMA and also BZ2, 
RPM, CPIO, DEB, RAR.
- Extended  search function with full text search in any files
- Configurable button bar to start external programs or internal menu commands
- Total Commander WCX, WDX and WLX plug-ins support
- File operations logging

Fedora Account System Username: cicku

--- Additional comment from Mario Blättermann on 2013-08-04 21:58:56 CEST ---

A *.desktop file needs to be installed explicitely or validated:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

Besides that, desktop-file-utils are needed as a build requirement.

The package contains the file /usr/bin/doublecmd. The same file is in the
package doublecmd-gtk2 (bug #989792), which would cause a package conflict. You
have added a Conflicts: tag to both packages, but I wouldn't recommend this
really. You should try to package both from the same source rpm instead and
rename the files appropriately. If you would do so, you could move the files
shared between the two versions to a -common subpackage (noarch), such as docs,
icons, man pages, wherever possible.

--- Additional comment from Christopher Meng on 2013-08-05 03:21:50 CEST ---

(In reply to Mario Blättermann from comment #1)
> A *.desktop file needs to be installed explicitely or validated:
> http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

Fixed.

> The package contains the file /usr/bin/doublecmd. The same file is in the
> package doublecmd-gtk2 (bug #989792), which would cause a package conflict.
> You have added a Conflicts: tag to both packages, but I wouldn't recommend
> this really. You should try to package both from the same source rpm instead
> and rename the files appropriately. If you would do so, you could move the
> files shared between the two versions to a -common subpackage (noarch), such
> as docs, icons, man pages, wherever possible.

I understand your meaning, but the fact is that Lazarus only supports one
widgetset(gtk2 or qt) in one time, so I cannot build them in one src rpm,

./build.sh beta qt

if then I run

./build.sh beta gtk2,

the newly built things will override the generated qt files.

This also happen in another package I haven't submitted.

--- Additional comment from Michael Schwendt (Fedora Packager Sponsors Group)
on 2013-08-05 10:23:18 CEST ---

At the end of %prep you could copy the builddir contents to a second builddir.

--- Additional comment from Christopher Meng on 2013-08-05 11:11:30 CEST ---

(In reply to Michael Schwendt from comment #3)
> At the end of %prep you could copy the builddir contents to a second
> builddir.

After consulting with upstream, they said that I can use another way:

./build.sh beta gtk2
./build.sh save gtk2

and

./build.sh beta qt
./build.sh save qt

then 

install/linux/install.sh gtk2 from saved gtk2 and install/linux/install.sh qt4
from saved qt4.

Is it alright?

I don't have time today, tomorrow may have a try.

--- Additional comment from Michael Schwendt (Fedora Packager Sponsors Group)
on 2013-08-16 21:35:44 CEST ---

> Is it alright?

Dunno. I haven't examined the source code that much. One more general way is to
create a copy of the source tree (e.g. in %prep), so you get two trees which
you can configure differently (likely with a strict set of
--enable-foo/--disable-foo options).

--- Additional comment from Mario Blättermann on 2013-10-20 20:00:27 CEST ---

Is there any decision made how to proceed with doublecmd? In any case, you
should close one ticket of doublecmd-qt and doublecmd-gtk. It would be odd to
generate to srpms for the two packages.

--- Additional comment from Mario Blättermann on 2013-10-31 20:05:33 CET ---

Any progress here...?

--- Additional comment from Mario Blättermann on 2013-11-16 16:32:25 CET ---

(In reply to Mario Blättermann from comment #7)
> Any progress here...?

Same question again...?

Anyway, you should open a new review ticket for doublecmd and mark
doublecmd-qt4 and doublecmd-gtk2 as duplicates. In fact both of the current
tickets are NotReady.

--- Additional comment from Raphael Groner on 2014-03-28 15:16:19 CET ---

(In reply to Mario Blättermann from comment #7)
> Any progress here...?

http://vondruch.fedorapeople.org/doublecmd/

--- Additional comment from Raphael Groner on 2014-12-11 18:14:40 CET ---

Should I take the request by clone this bug and closing?

--- Additional comment from Raphael Groner on 2015-02-05 16:16:04 CET ---

Hi Christopher,

are you still interested in mainting this package? If not, I would suggest to
consider this as a dead review, unfortunately.

--- Additional comment from Raphael Groner on 2015-02-25 17:03:52 CET ---

Ping? Again?

--- Additional comment from Christopher Meng on 2015-02-26 04:14:39 CET ---

(In reply to Raphael Groner from comment #12)
> Ping? Again?

--- Additional comment from Raphael Groner on 2015-03-30 16:32:31 CEST ---

WTF? What's this here? No progress since monthes. Sorry to raise and sound
unfriendly but this issue here is generally no acceptable process.

--- Additional comment from Raphael Groner on 2015-04-03 22:34:08 CEST ---

Taking over here. Closing.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=989791
[Bug 989791] Review Request: doublecmd-qt4 - Twin-panel (commander-style)
file manager(Qt4)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]