https://bugzilla.redhat.com/show_bug.cgi?id=1208911 --- Comment #18 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok licensing: ok sources: ok 926bd7bea6bccd2c618d97d39cc7d4ad doublecmd-0.6.4-src.tar.gz 1. MUST use desktop-file-install or desktop-file-validate for application .desktop files, see http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files macros: ok scriptlets: ok (n/a) 2. SHOULD reconsider the need for -plugins subpkg, what's the use-case for this optional component (rather than just including it all in the main pkg)? 3. SHOULD include only one (or none?) of these in the main pkg, Suggests: %{name}-qt = %{version}-%{release} Suggests: %{name}-gtk = %{version}-%{release} Including both doesn't give dnf any hint/help as to which to pick by default. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review