https://bugzilla.redhat.com/show_bug.cgi?id=1176595 --- Comment #5 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Sinny Kumari from comment #4) > This is un-official review of the package > > Few suggestions in spec file: > * In BuildRequires section, it is preferred to write each build require > package in new line unless they are related. For example in your spec file > you can write gcc-c++ and gcc-gfortran in same line, libtool and > libtool-ltdl-devel in one line. I don't see that in the guidelines and rpmlint doesn't complain. Where is it documented? > * In %files section, %defattr is not needed unless you are changing default > permission That's from the template that the guidelines recommend using. I thought it was required for EPEL5, but apparently not, so that's a bug in rpmdevtools if it's wrong. > Also, its good to give successful scratch build link of package in koji Where's that documented? It seems like a waste of time/resources to duplicate. I've probably missed other things like that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review