https://bugzilla.redhat.com/show_bug.cgi?id=1176595 --- Comment #6 from Sinny Kumari <ksinny@xxxxxxxxx> --- This is un-official review of the package Hi, Comments mentioned by me were suggestions not a blocker, they are not mandatory to follow. > > * In BuildRequires section, it is preferred to write each build require > > package in new line unless they are related. For example in your spec file > > you can write gcc-c++ and gcc-gfortran in same line, libtool and > > libtool-ltdl-devel in one line. > > I don't see that in the guidelines and rpmlint doesn't complain. Where is it > documented? This is not mentioned on fedora packaging guideline wiki but I got this feedback for my package from package reviewer https://bugzilla.redhat.com/show_bug.cgi?id=1182261#c1 , so thought of sharing. > > > * In %files section, %defattr is not needed unless you are changing default > > permission > > That's from the template that the guidelines recommend using. I thought it > was required for EPEL5, but apparently not, so that's a bug in > rpmdevtools if it's wrong. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics > > Also, its good to give successful scratch build link of package in koji > > Where's that documented? It seems like a waste of time/resources to > duplicate. https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request Its last point says "For bonus points, include a link to a successful koji build so that everyone knows you did all of your homework" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review