https://bugzilla.redhat.com/show_bug.cgi?id=1176595 Sinny Kumari <ksinny@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksinny@xxxxxxxxx --- Comment #4 from Sinny Kumari <ksinny@xxxxxxxxx> --- This is un-official review of the package Few suggestions in spec file: * In BuildRequires section, it is preferred to write each build require package in new line unless they are related. For example in your spec file you can write gcc-c++ and gcc-gfortran in same line, libtool and libtool-ltdl-devel in one line. * In %files section, %defattr is not needed unless you are changing default permission Also, its good to give successful scratch build link of package in koji -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review