Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890491 --- Comment #5 from Steven Roberts <strobert@xxxxxxxxxx> --- thank you for the review. what are you using? it looks different than at last the version of fedora-review I have been running. I would like to prescreen future packages to save folks some time. EPEL5 is a target so the following are still required: TODO: Remove BuildRoot definition. It's not needed any more. TODO: Remove explicit build root cleaning, it's not needed any more. TODO: Remove deleting empty directories in %install section. Modern ExtUtils::MakeMaker does not leave empty directories. TODO: Remove explicit %clean, it's not needed any more. TODO: Remove explicit defattr in %files section. It's not needed any more. Fixed these: TODO: Build-require `perl(constant)' (lib/Mail/Procmail.pm:155). TODO: Build-require `perl(Exporter)' (lib/Mail/Procmail.pm:162). FIX: Build-require `perl(Carp)' (lib/Mail/Procmail.pm:189). I'm working with the spanspec author on a new version, I'll see about why those weren't caught by it. new spec,srpm uploaded Spec URL: http://rpm.ysl.org/fedora-review/perl-Mail-Procmail.spec SRPM URL: http://rpm.ysl.org/fedora-review/perl-Mail-Procmail-1.08-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uVKjY1u92O&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review