Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890491 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Mail-Procmail.spec.old 2012-12-31 04:08:04.000000000 +0100 +++ perl-Mail-Procmail.spec 2013-01-24 04:54:40.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-Mail-Procmail Version: 1.08 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Procmail-like facility for creating easy mail filters License: GPL+ or Artistic Group: Development/Libraries @@ -12,6 +12,9 @@ BuildRequires: perl(LockFile::Simple) BuildRequires: perl(Mail::Internet) BuildRequires: perl(Test::More) +BuildRequires: perl(Carp) +BuildRequires: perl(constant) +BuildRequires: perl(Exporter) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %{?perl_default_filter} @@ -52,6 +55,9 @@ %{_mandir}/man3/* %changelog +* Wed Jan 23 2013 Steven D. Roberts <strobert@xxxxxxxxxx> 1.08-3 +- added some missing buildreqs + * Sun Dec 30 2012 Steven D. Roberts <strobert@xxxxxxxxxx> 1.08-2 - spec cleanup. > TODO: Remove BuildRoot definition. It's not needed any more. > TODO: Remove explicit build root cleaning, it's not needed any more. > TODO: Remove deleting empty directories in %install section. Modern ExtUtils::MakeMaker does not leave empty directories. > TODO: Remove explicit %clean, it's not needed any more. > TODO: Remove explicit defattr in %files section. It's not needed any more. Not addressed. > TODO: Build-require `perl(constant)' (lib/Mail/Procmail.pm:155). +BuildRequires: perl(constant) Ok. > TODO: Build-require `perl(Exporter)' (lib/Mail/Procmail.pm:162). +BuildRequires: perl(Exporter) Ok. > FIX: Build-require `perl(Carp)' (lib/Mail/Procmail.pm:189). +BuildRequires: perl(Carp) Ok. $ rpmlint perl-Mail-Procmail.spec ../SRPMS/perl-Mail-Procmail-1.08-3.fc19.src.rpm ../RPMS/noarch/perl-Mail-Procmail-1.08-3.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4898744). Ok Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ya3UV992Jr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review