Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890491 --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- (In reply to comment #5) > thank you for the review. what are you using? it looks different than at > last the version of fedora-review I have been running. I would like to > prescreen future packages to save folks some time. > No tool, manually. We have plan to write the test as plug-in for fedora-review, but fedora-review is broken now. > EPEL5 is a target so the following are still required: > > TODO: Remove explicit defattr in %files section. It's not needed any more. This is not needed since rpm 4.4 which presents in RHEL-5 <https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions>. > Fixed these: > TODO: Build-require `perl(constant)' (lib/Mail/Procmail.pm:155). > TODO: Build-require `perl(Exporter)' (lib/Mail/Procmail.pm:162). > FIX: Build-require `perl(Carp)' (lib/Mail/Procmail.pm:189). > > I'm working with the spanspec author on a new version, I'll see about why > those weren't caught by it. cpanspec investigates META.yml only. And even so it removes modules which are bundled with perl. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MuoCd5GLrt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review