Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890491 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source file is original (SHA-256: 09ff5367e83a752f1279f31d8ac05b62360222bb438dc58a71f7e39506298c70). Ok. Summary verified from lib/Mail/Procmail.pm. Ok. Description verified from lib/Mail/Procmail.pm. Ok. License verified from lib/Mail/Procmail.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Remove BuildRoot definition. It's not needed any more. TODO: Remove explicit build root cleaning, it's not needed any more. TODO: Remove deleting empty directories in %install section. Modern ExtUtils::MakeMaker does not leave empty directories. TODO: Remove explicit %clean, it's not needed any more. TODO: Remove explicit defattr in %files section. It's not needed any more. TODO: Build-require `perl(constant)' (lib/Mail/Procmail.pm:155). TODO: Build-require `perl(Exporter)' (lib/Mail/Procmail.pm:162). FIX: Build-require `perl(Carp)' (lib/Mail/Procmail.pm:189). IO::File is not needed on current perl. Ok. All tests pass. Ok. $ rpmlint perl-Mail-Procmail.spec ../SRPMS/perl-Mail-Procmail-1.08-2.fc19.src.rpm ../RPMS/noarch/perl-Mail-Procmail-1.08-2.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Mail-Procmail-1.08-2.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 21 16:03 /usr/share/doc/perl-Mail-Procmail-1.08 -rw-r--r-- 1 root root 2339 Sep 19 2004 /usr/share/doc/perl-Mail-Procmail-1.08/CHANGES -rw-r--r-- 1 root root 3729 Sep 19 2004 /usr/share/doc/perl-Mail-Procmail-1.08/README -rw-r--r-- 1 root root 6956 Jan 21 16:03 /usr/share/man/man3/Mail::Procmail.3pm.gz drwxr-xr-x 2 root root 0 Jan 21 16:03 /usr/share/perl5/vendor_perl/Mail -rw-r--r-- 1 root root 22214 Sep 19 2004 /usr/share/perl5/vendor_perl/Mail/Procmail.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Mail-Procmail-1.08-2.fc19.noarch.rpm |sort |uniq -c 1 perl >= 0:5.005 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(LockFile::Simple) 1 perl(Mail::Internet) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(Sys::Hostname) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Mail-Procmail-1.08-2.fc19.noarch.rpm |sort |uniq -c 1 perl(Mail::Procmail) = 1.08 1 perl-Mail-Procmail = 1.08-2.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Mail-Procmail-1.08-2.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4889603). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D8LQSSJvQl&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review