Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #24 from Ismael Olea <ismael@xxxxxxxx> --- (In reply to comment #22) > You could also lose > > %global versionr 1.7.5-v1 done > But are they required for the package to function? (I can see one referenced > in the source but I was hoping you'd tell me that) As a packager, while it obeys Fedora guidelines I don't want to inquire if every bit from upstream is really used or not. That could be a interesting effort as a code contributor but it's not my interest here. OTOH, it seems to bootstrap a subversion server so, yes, it's part of sw feature. > The previous maintainer repacked the source such that the nailgun.jar was > _not even shipped_ with the SRPM. I'm asking the why you have changed this > policy. This is a very valid question. For the license concerns reported by @Stanislav I added a ASL 2.0 license inside SRPM > I'd like to see your %prep section at least remove all *.jars and *.class > files (with the exception of template.jar) above to ensure upstream doesn't > slip something in at a later release. This is good policy and is mentioned > in the java packaging guidelines. My work process is to explicit remove each one jar file. It's completely expresive and helps package maintenance, ie: detecting new revisions on dependencies or new dependencies by itself. And not all recomendations on guidelines are about deleting but detecting. Check de the example snippet at https://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software Anyhow, I added a find command to visualize any potential issue. > The rest of the package is looking really good. thanks here it is the new release: http://olea.org/tmp/omegat-fedora-feature/svnkit.spec http://olea.org/tmp/omegat-fedora-feature/svnkit-1.7.6-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2KDgDnl98q&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review