Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #25 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- (In reply to comment #24) > > I'd like to see your %prep section at least remove all *.jars and *.class > > files (with the exception of template.jar) above to ensure upstream doesn't > > slip something in at a later release. This is good policy and is mentioned > > in the java packaging guidelines. > > My work process is to explicit remove each one jar file. It's completely > expresive and helps package maintenance, ie: detecting new revisions on > dependencies or new dependencies by itself. > > And not all recomendations on guidelines are about deleting but detecting. > Check de the example snippet at > https://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_. > 2F_Other_bundled_software If you read the snippet closely you'll notice it calls exit 1 if it finds any binary files. Current svnkit spec does: find -name *jar -or -name *.class|grep -v class Which rougly translates to "look for jar files and class files and print just jar". You or other packager *will* miss new binary jar addition this way. Something which would be much better in my opinion: # delete every jar/class except whitelisted JAR_WHITELIST="\(template.jar\)" find . ! -regex ".*$JAR_WHITELIST.*" -and \ \( -name '*.jar' -or -name '*.class' \) \ -delete -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oMe8JpQRdm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review