Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 Stanislav Ochotnicky <sochotni@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sochotni@xxxxxxxxxx --- Comment #23 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- template.jar is OK, since it's just a tarball with some source templates. However (future) maintainer should make sure with each new upstream release that upstream didn't slip in some bundled binary code. as for nailgun.jar: having it in SRPM *looks* OK, but in that case you need to include ASL 2.0 license text to SRPM Sources (point 4.1 of ASL states you need to distribute license text together with sources/binaries). No need to install ASL 2.0 license since binary rpms don't contain any ASL 2.0 code it seems. That said, the jar should definitely be removed during %prep. Using binaries during build is strictly prohibited unless it's being used for bootstrapping (and you'd need FESCO exception even for that). More about bundling: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YxhwSLaogz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review