Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #22 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- You could also lose %global versionr 1.7.5-v1 (In reply to comment #20) > Previously this packaged removed all JARs from upstream and repackaged a > clean source. This included removing the template.jars as well. > > This leads me to two questions [1]: > - are the template.jar files required for the function to package function. But are they required for the package to function? (I can see one referenced in the source but I was hoping you'd tell me that) grep -nir template.jar * svnkit/src/main/java/org/tmatesoft/svn/core/io/SVNRepositoryFactory.java:110: private static final String REPOSITORY_TEMPLATE_PATH = "/org/tmatesoft/svn/core/io/repository/template.jar"; > - I'm assuming the previous maintainer had a good reason to repack the > source so that no jar's are shipped in the src.rpm and I'd just like you to > justify why you are not doing the same? The previous maintainer repacked the source such that the nailgun.jar was _not even shipped_ with the SRPM. I'm asking the why you have changed this policy. This is a very valid question. I'd like to see your %prep section at least remove all *.jars and *.class files (with the exception of template.jar) above to ensure upstream doesn't slip something in at a later release. This is good policy and is mentioned in the java packaging guidelines. The rest of the package is looking really good. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rnieUp1qcp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review