Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #21 from Ismael Olea <ismael@xxxxxxxx> --- (In reply to comment #20) > Things I'd like to see fixed: > > - please remove all unused variables. > %global svn_revision, %eclipse_name , core_plug*, version_r, jan_plugin* > are a few examples. > - Remove all the commented eclipse plugin sections. References of these > should be available in fedora before the package was orphaned so nothing > will be lost Ok... Here they are: http://olea.org/tmp/omegat-fedora-feature/svnkit.spec http://olea.org//tmp/omegat-fedora-feature/svnkit-1.7.6-2.fc19.src.rpm > Previously this packaged removed all JARs from upstream and repackaged a > clean source. This included removing the template.jars as well. > > This leads me to two questions [1]: > - are the template.jar files required for the function to package function. > - I'm assuming the previous maintainer had a good reason to repack the > source so that no jar's are shipped in the src.rpm and I'd just like you to > justify why you are not doing the same? It's not a bundled external dependency but an upstream jar. So I see no reason to remove while loyal with policy. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lyNkzQ6y3l&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review