Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877403 --- Comment #20 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- Things I'd like to see fixed: - please remove all unused variables. %global svn_revision, %eclipse_name , core_plug*, version_r, jan_plugin* are a few examples. - Remove all the commented eclipse plugin sections. References of these should be available in fedora before the package was orphaned so nothing will be lost Previously this packaged removed all JARs from upstream and repackaged a clean source. This included removing the template.jars as well. This leads me to two questions [1]: - are the template.jar files required for the function to package function. - I'm assuming the previous maintainer had a good reason to repack the source so that no jar's are shipped in the src.rpm and I'd just like you to justify why you are not doing the same? [1] http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XzMRcagU5o&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review