Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875450 --- Comment #3 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some quick comment: - There are static libs in your -devel package. https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries - Please check your %changelog entry https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs - Please use %global instead of %define - The rpmlint output is not clean: [fab@laptop11 review-srpm]$ rpmlint sstp-client-1.0.8-1.fc17.src.rpm sstp-client.src: E: description-line-too-long C A client implementation of Secure Socket Tunneling Protocol (SSTP) for Linux / Mac OS-X that allows remote access via SSTP VPN to Microsoft Windows 2008 Server. sstp-client.src: W: no-version-in-last-changelog sstp-client.src: W: strange-permission sstp-client.spec 0600L 1 packages and 0 specfiles checked; 1 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lR0c5YtSDc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review