[Bug 885120] Review Request: python-elfdata - Python wrapper to get ELF data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885120

--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Package build fine in mock

+ rpmlint on rpms gave
python-elfdata.src: W: invalid-url Source0:
https://github.com/downloads/kushaldas/elfdata/elfdata-0.4.tar.gz HTTP Error
404: Not Found
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

- Source verified with upstream as

+ follow python packaging guidelines

+ license is valid 

Suggestions:
* Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

* you may also want to remove 
buildroot
%clean
cleaning of buildroot in %install
python_sitearch macro


* Please add license, description in PKG-INFO file upstream

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W8E8nFGBmB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]