https://bugzilla.redhat.com/show_bug.cgi?id=843029 --- Comment #4 from Till Bubeck <t.bubeck@xxxxxxxxxxx> --- Thanks to all valuable feedback. I uploaded a new version: Spec URL: http://www.reinform.de/privat/bubeck/foxtrotgps.spec SRPM URL: http://www.reinform.de/privat/bubeck/foxtrotgps-1.1.1-1.fc17.src.rpm I changed the following, according to your review comments: * %{_datadir}/foxtrotgps/ now owned by package * No use of vendor tag during desktop file install. * No vendor prefix for desktop file * usage of package supplied desktop file instead of own file * No defattr anymore * libsoup-devel is no BuildReq anymore. However, I did NOT follow the following review comments: * "gpsd must not be a Requires". I still list "gpsd" as a Requires, because rpm found only "gpsd-libs" as a requirement and foxtrotgps needs gpsd itself. * "gpscorrelate and jhead" are still Requires, and yes, they are only needed for geotagging. I kept them, because I think both packages are very small (< 200 KB) and leaving them out will result in loss of functionality which is hard to re-establish for newbies. So could you please review once more and set the "fedora-review flag" if nothing is wrong anymore? Otherwise please tell me and I will update the package ASAP. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review