https://bugzilla.redhat.com/show_bug.cgi?id=843029 --- Comment #5 from Volker Fröhlich <volker27@xxxxxx> --- When submitting new copies for review, please always write a changelog entry and bump the release number. Reviewers can easily distinguish between the copies then. jhead and gpscorrelate are actually half a megabyte, but I'm fine with that. I'd personally leave a comment in the spec file, explaining why they are required. rpmbuild creates Requires for linked libraries. This is what you see when you run rpm -q --requires foxtrotgps: ... libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) >>>libgps.so.19()(64bit)<<< ... That's actually a lot better than just a name. It tells you when your package needs a rebuild, if there are incompatible ABI changes in a library. You therefore don't have to require gpsd. Rpmbuild figues it out itself, as it did for all the other libraries. You haven't addressed dbus from Michael's comment yet. %{_datadir}/foxtrotgps/foxtrotgps.glade -- This line is no longer necessary. If you don't go for EPEL 5: - Delete the clean section - Delete the first rm in the install section - Delete the buildroot definition Please decide for using either $RPM_BUILD_ROOT or %{buildroot}. I'd like to suggest again, to use the name macro, where it makes sense -- for instance in the desktop file. Cosmetics: Remove the trailing slash from the URL. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review