https://bugzilla.redhat.com/show_bug.cgi?id=843029 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> --- Danishka, why didn't you fill out the form completely? Updated on https://fedoraproject.org/wiki/GIS#Packages_on_review Waste defattr. Only EPEL 4 requires it. Also remove all specific EPEL 5 elements, if you don't go for it. Don't use vendor on the desktop file, as Michael already noticed, and don't use the fedora prefix. Also consider to use upstream's desktop file and add additional elements as described in http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files. gpsd must not be a Requires, as RPM adds this dependency on its own. gpscorrelate and jhead are only necessary for geotagging photos. I feel they should not be requirements. It seems to me, libsoup-devel is not necessary. Consider to use the name macro, where it makes sense. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review