Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 --- Comment #9 from fujiwara <tfujiwar@xxxxxxxxxx> 2010-06-10 07:32:59 EDT --- Revised spec file: http://github.com/fujiwarat/input-pad/commit/188f838f1ce0a8beb259c9df59dcd92b7e5a8eb4 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100608-2.fc13.src.rpm (In reply to comment #8) > 1) Please add more specific words of summary for this package. Like you can add > "An on-screen input pad used to input symbols easily." I accept this in this time since other issues are also reported. > 2) Before building in Fedora remove following un-necessary lines from SPEC > Requires: glib2 >= %glib2_version > Requires: gtk2 > Requires: libX11 > Requires: libxkbfile > Requires: libxklavier >= %libxklavier_version > Requires: libxml2 >= %libxml2_version > I didn't notice Linux rpmbuild has the feature of auto-dependency. I accept this useful suggestion now. Thanks. > 5) You should actually use following in %build to preserve upstream file's > timestamps. Not mandatory by reviewguidelines but suggested a good fix by > packaging guidelines. > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Cool. -p is useful. > 6) Make sure each change,if no new upstream version used then you bump the > release and provide new SPEC and SRPM. OK, I will remember the Fedora policy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review