Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #10 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-06-11 01:44:12 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2242129 + rpmlint outputs input-pad.x86_64: W: incoherent-version-in-changelog 0.1.0.20100608-1 ['0.1.0.20100608-2.fc13', '0.1.0.20100608-2'] input-pad.x86_64: W: shared-lib-calls-exit /usr/lib64/libinput-pad.so.0.0.1 exit@xxxxxxxxxxx input-pad.x86_64: W: no-manual-page-for-binary input-pad input-pad-devel.x86_64: W: no-documentation input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad.so _input_pad.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_window_gtk.so _input_pad_window_gtk.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_group.so _input_pad_group.so()(64bit) input-pad-python.x86_64: W: no-documentation input-pad-xtest.x86_64: E: explicit-lib-dependency libXtst input-pad-xtest.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 9 warnings. + source files match upstream url (sha1sum) 11b4c1c69c5bf4a7d8abfe7172a72b75caab8c2a input-pad-0.1.0.20100608.tar.gz.srpm 11b4c1c69c5bf4a7d8abfe7172a72b75caab8c2a input-pad-0.1.0.20100608.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not required for F-13 and above builds. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + input-pad.pc file present. + -devel, -python, -xtest subpackage exists + no .la files. + translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package input-pad-0.1.0.20100608-2.fc13.x86_64 => Provides: libinput-pad.so.0()(64bit) Requires(interp): /sbin/ldconfig /sbin/ldconfig Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= Requires: libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) + PAckage input-pad-devel-0.1.0.20100608-2.fc13.x86_64=> Provides: pkgconfig(input-pad) = 0.1.0.20100608 Requires: /usr/bin/pkg-config libinput-pad.so.0()(64bit) pkgconfig(glib-2.0) pkgconfig(libxml-2.0) >= 2.0 + Package input-pad-python-0.1.0.20100608-2.fc13.x86_64 => Provides: _input_pad.so()(64bit) _input_pad_group.so()(64bit) _input_pad_window_gtk.so()(64bit) Requires: libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpython2.6.so.1.0()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) python(abi) = 2.6 rtld(GNU_HASH) + Package input-pad-xtest-0.1.0.20100608-2.fc13.x86_64 => Provides: libinput-pad-xtest-gdk.so()(64bit) Requires: libX11.so.6()(64bit) libXtst.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) + Not a GUI application Suggestions: 1) Please add changelog entry for each release bump. You have wrong changelog entry with -1 as release whereas you have Release tag saying its -2 release. 2) you also don't need Requires: libXtst please remove it before you build in cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review