Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 --- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-06-10 05:44:42 EDT --- Suggestions: 1) Please add more specific words of summary for this package. Like you can add "An on-screen input pad used to input symbols easily." 2) Before building in Fedora remove following un-necessary lines from SPEC Requires: glib2 >= %glib2_version Requires: gtk2 Requires: libX11 Requires: libxkbfile Requires: libxklavier >= %libxklavier_version Requires: libxml2 >= %libxml2_version 3) You can remove redundant BuildRequires BuildRequires: glib2-devel >= %glib2_version BuildRequires: libX11-devel as gtk2-devel will install them. However, I see gtk2-devel specifies glib2 version 2.23.6 and you specified 2.8 4) for have_python_devel, you should be using macros %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif 5) You should actually use following in %build to preserve upstream file's timestamps. Not mandatory by reviewguidelines but suggested a good fix by packaging guidelines. make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 6) Make sure each change,if no new upstream version used then you bump the release and provide new SPEC and SRPM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review