Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490576 --- Comment #6 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-18 12:05:01 EDT --- (In reply to comment #5) > > - Install phase: use 'make install DESTDIR=$RPM_BUILD_ROOT' instead of 'make > > install prefix=%{buildroot} BINDIR=%{buildroot}%{_bindir} > > MANDIR=%{buildroot}%{_mandir}'. > > Original Makefile does a mess with file copying and doesnt use install, so just > passing DESTDIR makes the build fail. Very well, then the first version was OK. The patching with perl/sed is OK too, maybe even a bit tidier. - The package includes documentation that can be built - please add BuildRequires: hevea BuildRequires: tex(latex) and make doc to the spec file. Include manual.ps and manual.html (and maybe also manual.dvi) to documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review