Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490576 --- Comment #5 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2009-03-18 11:40:32 EDT --- (In reply to comment #4) > - You should increment the release number every time you make changes to the > package. Now it's hard to tell what changes you have made inbetween versions. > Also remember to add a comment to the changelog about what you have done in > each release. > - Change the source line to use %{version} instead of the version number. This > way when a new version comes out you only need to change the Version: tag. > > - Character set conversion is not done safely, use: > for file in CHANGES ; do > mv $file timestamp && \ > iconv -f ISO-8859-1 -t UTF-8 -o $file timestamp && \ > touch -r timestamp $file && \ > rm timestamp > done > > - No need to set prefix in %configure, since the %configure macro already does > it (among a bunch of other things). Just use %configure. ok (for the first one, i just didnt consider this one a release until approval!) > - Is there a reason why you're not enabling SMP make? Use 'make > %{?_smp_mflags}' instead of plain 'make'. Not actually, added it and package was built cleanly; i used 'rpmdev-newspec -t ocaml' at start and flag was not proposed (specifying -t ocaml seems to be best suited to package libraries, am i wrong?) > - Install phase: use 'make install DESTDIR=$RPM_BUILD_ROOT' instead of 'make > install prefix=%{buildroot} BINDIR=%{buildroot}%{_bindir} > MANDIR=%{buildroot}%{_mandir}'. Original Makefile does a mess with file copying and doesnt use install, so just passing DESTDIR makes the build fail. I may do something like %{__perl} -pi -e 's|^BINDIR=.*|BINDIR=%{buildroot}%{_bindir}|g;' Makefile but that would require perl. Sending a patch upstream would be best choice i think, but im not willing to editing a handwritten Makefile (i'm a java developer after all) Files here: http://guidograzioli.fedorapeople.org/packages/bibtex2html Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review