On Tue, Feb 20, 2024 at 09:45:49AM +0100, Michael J Gruber wrote: > Am Di., 20. Feb. 2024 um 09:21 Uhr schrieb Loren M. Lang > <lorenl@xxxxxxxxxxxxxxx>: > > > > On Sun, Feb 18, 2024 at 06:08:53AM -0300, Priscila Gutierres wrote: > > > I created this post based on my own experience: > > > https://dev.to/prinewgirl/a-recipe-made-to-create-your-first-pr-for-the-fedora-project-21be > > > Hope it helps. > > > > Thanks, with these and an Kan-Ru's instructions, I was able to > > successfully push up my changes to my fork on Pagure. However, I did > > have one issue with the sources. The push initially failed with the > > error: > > > > Source file (or tarball) 'cachelib-0.12.0.tar.gz' wasn't uploaded > > to the lookaside cache. > > > > I assume that this is another restriction of not being a packager? > > However, I didn't see this addressed in the provided docs. I was able to > > bypass it with --no-verify, but the Fedora CI build that was triggered > > when I made my Pull Request fails since it couldn't find the uploaded > > sources. > > > > I was able to manually submit a passing CI build by pushing up the SRPM. > > > > Hi there, > > I've uploaded the sources to the lookaside cache for you, after > checking and confirming what you had checked already. I guess that is > the reason why uploads are allowed for packagers only - because you > confirm upfront that you will do these checks :) Thanks! I see most of the automatic CI tests are running and passing after my push now that the sources are present. However, there is one odd failure dist-git test. Too many arguments provided to cd. I suspect it froms from this line in metadata.yml for the Ansible recipe running the test: cd $TMT_SOURCE_DIR/*/ Likely, it's expanding to a path with a space, but I don't see anything on my end that should be causing the issue. > > As for the PR, it's the maintainer's decision, of course. I would > rewrite history at least to fold sources update in with the spec file > bump, and probably also the updated test exceptions. I followed your suggestion and squashed those commits together. Thanks, Loren > > Cheers > Michael > -- > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue -- Loren M. Lang lorenl@xxxxxxxxxxxxxxx http://www.north-winds.org/ Public Key: http://www.north-winds.org/lorenl_pubkey.asc Fingerprint: 7896 E099 9FC7 9F6C E0ED E103 222D F356 A57A 98FA
Attachment:
signature.asc
Description: PGP signature
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
