Dne 20. 02. 24 v 9:21 Loren M. Lang napsal(a):
On Sun, Feb 18, 2024 at 06:08:53AM -0300, Priscila Gutierres wrote:I created this post based on my own experience: https://dev.to/prinewgirl/a-recipe-made-to-create-your-first-pr-for-the-fedora-project-21be Hope it helps.Thanks, with these and an Kan-Ru's instructions, I was able to successfully push up my changes to my fork on Pagure. However, I did have one issue with the sources. The push initially failed with the error: Source file (or tarball) 'cachelib-0.12.0.tar.gz' wasn't uploaded to the lookaside cache. I assume that this is another restriction of not being a packager?
Yes, this is expected. You can us `fedpkg` with `--offline` param to explicitly avoid this issue.
However, I didn't see this addressed in the provided docs. I was able to bypass it with --no-verify, but the Fedora CI build that was triggered when I made my Pull Request fails since it couldn't find the uploaded sources.
Uploading sources for PR or not, that is a bit grey zone due to possible issue with uploading legally problematic code.
I was able to manually submit a passing CI build by pushing up the SRPM.
But having the legally problematic code in SRPM would not be any better I guess :)
Vít
-LorenEm dom., 18 de fev. de 2024 às 05:32, Ondrej Mosnáček <omosnacek@xxxxxxxxx> escreveu:On Sun, 18 Feb 2024 at 09:23, Kan-Ru Chen <kanru@xxxxxxxxxx> wrote:Hi, On Sun, Feb 18, 2024, at 10:52 AM, Loren M. Lang wrote:I've cloned it down and worked on bringing it more up-to-date. Now that I have something passing the test suite, I thought I'd file a PR and start a discussion. I forked the project on Pagure.io, but found that even with my own personal fork, I don't seem to have commit access toitwithout being in the Packagers group. Is that standard? I thought the point of the fork was to allow non-packagers to use the PR mechanism as an easy mechanism for sponsors to view proposals. In any case, I decided to through it up on GitHub temporarily so Icouldat least create a Remote PR. https://src.fedoraproject.org/rpms/python-cachelib/pull-request/6I have recently done this. You need to use fedpkg to clone therepository thenit will setup the hook for authentication with FAS. For example if you have fork at `fork/penguin359/rpms/python-cachelib`then usethis command to clone fedpkg clone -a forks/penguin359/rpms/python-cachelib then in the cloned repo you can push normally.FWIW. it is documented here: https://docs.fedoraproject.org/en-US/ci/pull-requests/#_you_are_not_a_packager -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
