Re: Help with creating first PR for a package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Di., 20. Feb. 2024 um 09:21 Uhr schrieb Loren M. Lang
<lorenl@xxxxxxxxxxxxxxx>:
>
> On Sun, Feb 18, 2024 at 06:08:53AM -0300, Priscila Gutierres wrote:
> > I created this post based on my own experience:
> > https://dev.to/prinewgirl/a-recipe-made-to-create-your-first-pr-for-the-fedora-project-21be
> > Hope it helps.
>
> Thanks, with these and an Kan-Ru's instructions, I was able to
> successfully push up my changes to my fork on Pagure. However, I did
> have one issue with the sources. The push initially failed with the
> error:
>
> Source file (or tarball) 'cachelib-0.12.0.tar.gz' wasn't uploaded
> to the lookaside cache.
>
> I assume that this is another restriction of not being a packager?
> However, I didn't see this addressed in the provided docs. I was able to
> bypass it with --no-verify, but the Fedora CI build that was triggered
> when I made my Pull Request fails since it couldn't find the uploaded
> sources.
>
> I was able to manually submit a passing CI build by pushing up the SRPM.
>

Hi there,

I've uploaded the sources to the lookaside cache for you, after
checking and confirming what you had checked already. I guess that is
the reason why uploads are allowed for packagers only - because you
confirm upfront that you will do these checks :)

As for the PR, it's the maintainer's decision, of course. I would
rewrite history at least to fold sources update in with the spec file
bump, and probably also the updated test exceptions.

Cheers
Michael
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux