Re: Review Request: ImageMagick7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 6, 2022 at 10:49 AM Kevin Kofler via devel
<devel@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Neal Gompa wrote:
> > There are actually
> > other packages I could fix in Fedora with patches from openSUSE or
> > PLD, but they need more work to not break compatibility with building
> > with GraphicsMagick (which these packages in question support), so
> > using IM6 there for now is fine while that gets worked out.
>
> If there are patches, I do not see why we cannot just apply them downstream
> instead of building against a compat package, especially if we make
> ImageMagick 7 the default as you propose.
>
> There is no rule in Fedora that any and all patches must be upstreamed.
> Especially building against the distribution's version of a library is
> exactly what a distribution is for and hence the perfect example of when it
> makes sense to patch a package.
>

While that is true, *I* don't like doing that if I don't have to. I'd
rather try to get things fixed upstream in tandem. Upstreams tend to
appreciate that in my experience. :)

(This is probably why so many people think I'm everywhere, to be honest! :P )

> IMHO, either we go with Sergio's plan, letting ImageMagick be version 6
> forever and introducing ImageMagick7 (and in the future ImageMagick8, etc.)
> for all newer versions, then we can slowly switch packages from ImageMagick
> to ImageMagick7, or we go with your plan and move ImageMagick to version 7,
> but then we should do all we can to make really everything use the new
> version.
>

As I said earlier in the thread: of the 25 reverse dependencies of the
ImageMagick libraries, only five don't build[1].

Further analysis indicates that dvdauthor has a patch in openSUSE[2],
but the fix breaks support for GraphicsMagick as an alternative. I
want to rework that patch so it doesn't break GraphicsMagick and old
ImageMagick support so that it's suitable for upstreaming. I don't
expect this to be too difficult to do.

[1]: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/24CLLA46CAIKWRSPYVLZFLDPLTPRDU7U/
[2]: https://code.opensuse.org/package/dvdauthor/blob/master/f/dvdauthor-0.7.2-imagemagick7.patch


-- 
真実はいつも一つ!/ Always, there's only one truth!
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux