On 12/7/21 16:18, Nico Kadel-Garcia wrote:
On Tue, Dec 7, 2021 at 5:46 AM Panu Matilainen <pmatilai@xxxxxxxxxx> wrote:
On 12/5/21 05:07, Nico Kadel-Garcia wrote:
I've been trying to bundle the current ansible-5.0.1 release as an RPM
for Fedora and EPEL use. Leaving aside the peculiar decisions to
replace the pypi.org "ansible" tarball with a tarball of roughly 150
modules from the "ansiblee-collections" repos, and moving the actual
ansible software to a distinct python tarball called "ansible-core"
without changing the source repo or the actual critical installed
python modules, the new "ansible" has more than 300 files called
"README.md" and more than 100 files called "LICENSE.md".
This breaks building RPMs for EPEL 8 or Fedora, because the '%doc' and
'%license' macros strip off the subdirectories of the files and
install them directly at the top of the docdir.
Basicely these only generate one file:
%doc README.md
%doc dir1/README.md
%doc dir2/README.md
%license LICENSE.md
%license dir1/LICENSE
%license dir2/LICENSE.md
When compiled, these would only produce:
/usr/share/doc/package-%{fersion}/README.md
/usr/share/doc/package-%{fersion}/LICENSE.md
RHEL 7 didn't have this problem. I'm not sure if other folks have
noticed this for tools that are built with multiple internal tarballs.
The new "ansible" tarball is fairly unique ints authors insistance on
putting more than one hundred distinct third party packages in the
same master tarball. But for now, this is going to cause a license and
documentation problem in packaging it due to an "optimization" of
stripping out the directory names of document files and licenses.
Does anyone know a decent workaround, or a specfile setting to disable
this filename stripping and restore the RHEL 7 behavior?
There were changes in how %doc is handled around rpm 4.13 (whereas
RHEL-7 has 4.11), maybe there's a regression that nobody noticed (or
complained about) until now. The use-case there seems quite reasonable
to me.
File a bug on rpm (preferably upstream ticket) to have it looked at.
- Panu -
I've submitted one, at https://bugzilla.redhat.com/show_bug.cgi?id=2029877 .
It seems that the problem existed as well with earlier versions of
rpmbuild, say on RHEL 7, but the warning messages about "files listed
twice" weren't generated. And various slightly differently named
README.md and LICENSE.md files make it not as obvious as one might
expect.
Okay, but since it happens on RHEL 7 too then there's no regression. I
thought the leading directories were always stripped but given your
strong statement about RHEL 7 not having this issue I thought maybe I'm
missing something.
The current behavior is good for other use-cases and we can't go just
changing it, but this is a totally legit (and common, I think) use-case
so maybe we can come up with something to optionally not strip leading
directories.
- Panu -
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
