On Fri, Mar 1, 2019 at 9:58 AM Adam Samalik <asamalik@xxxxxxxxxx> wrote: > > I'm glad Modularity is getting popular, however, we should coordinate such big changes so we keep consistency among various build environments. I'd call it "notorious" or "infamous" instead of "popular", but that's just a difference perspective ;) > The ability to enable modules in a Koji buildroot is being discussed in a FESCo ticket [1] — although that discussion is a bit longer than initially anticipated. But when that's done, we'll be finally able to move content from traditional packages to default modules when desired. And that'll be the best time to enable the modular repo in Mock so it behaves consistently with Koji. I agree, this change to mock-core-configs seems to have been rushed and uncoordinated, since it's not possible to use modules in koji at all. Can we find some middle ground here? Maybe two different configs (e.g. fedora-29-x86_64 and fedora-29-modular-x86_64), where the first one preserves the expected behaviour, and the new one enables modular repositories for the people who want to test this out? Either way, I'm just strongly opposed to enable modular repos in mock by default (yet). (Maybe I should have added a (yet) to the subject to this e-mail, as well.) Fabio > [1] https://pagure.io/fesco/issue/2003 > > On Fri, Mar 1, 2019 at 9:49 AM Dan Horák <dan@xxxxxxxx> wrote: >> >> On Fri, 1 Mar 2019 08:59:35 +0100 >> Miroslav Suchý <msuchy@xxxxxxxxxx> wrote: >> >> > Dne 01. 03. 19 v 0:22 Miro Hrončok napsal(a): >> > > On 01. 03. 19 0:05, Fabio Valentini wrote: >> > >> I don't want or need modules installed for this package to build. >> > >> > It may be true if your specific case. But generally this is not true. >> > AFAIK Some packages are not available in normal repo any more and are >> > available only in modules. E.g., stratis* packages. The general >> > expectaion is that more and more packages will move to modules. >> > >> > >> Any insights why this was done? >> > >> > Mock is in fact just easy tool to run 'rpmbuild' in minimal chroot of >> > Fedora/CentOS. So running >> > >> > mock -r fedora-29-x86_64 foo.src >> > >> > should give you the same results as running `rpmbuild --rebuild >> > foo.src` on normal installation of fedora-29 with only minimal >> > installation. And /etc/yum.repos.d/fedora-modular.repo *is* part of >> > Fedora 29+. Therefore it is in mock configs. If you do not need it >> > appeal either: >> > * maintainer of fedora-repos package >> > * modularity team >> > * FESCO representatives >> > >> > > Mock should IMHO bring the exact same (or at least the most >> > > similar) results as building in koji. I don't want to get different >> > > packages in mock and Koji just because the configurations are >> > > different. >> > > >> > > Let's make the defaults the sme as Koji (currently, that means no >> > > modular repos). >> > >> > Nope, it is the other way round. Koji use Mock and therefore Koji >> > builds should be the same as your local builds with local mock. >> > Only Koji admins do not jump on every released version and should >> > (and I hope they do) test every new released version if it does not >> > break Koji builds. >> >> koji provides own mock configs for the builds pointing to the internal >> repos, it doesn't use the configs distributed with mock at all >> >> >> Dan >> _______________________________________________ >> devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx >> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx >> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines >> List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > > > > -- > > Adam Šamalík > --------------------------- > Software Engineer > Red Hat > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
