On 02/14/2018 04:47 PM, Reindl Harald wrote: > Am 14.02.2018 um 22:27 schrieb David Cantrell: >> I am not disputing the policy. I feel this change is pointless and is a >> lot of commits for no real benefit. They are not fixes. You're just >> scrubbing spec files that are not broken. Who cares? Update the >> packaging policy and be done with it > > yeah, that's how most rpm-specs in Fedora look like "who cares, it works > somehow, i can live with the mess" - for packages where i decided to > start maintain them on my own i started with remove evrything i don't > understand why it is needed and a large part of the specs was just gone > and the remaining ones are clear > > WTF - instead say thank you that somebody *does something* in Fedora > instead talking and write pointless guidelines nobody seems to care > about in the project a view people are pissed that he did the work teey > should have been done long before as maintainer - seriously? I'll back up. I combined both my opinion of the change itself and how I feel the change should be approached in Fedora. First, I actually don't care if this change is made or not. My personal opinion is that it's a nice-to-have cleanup that will probably not cause problems, but you never know with that many packages. So that's why I feel it should be approached using pull requests. We have that functionality now thanks to Pagure, which is something we *never* had in dist-cvs or the former git system. Is that tedious? Yeah, it is. But pushing a change like that across many packages will not necessarily explain to package maintainers why that was done. If packages have not been cleaned up in that amount of time and things are still building, I question the urgency of the change. Pull requests give package maintainers an opportunity to be part of this change. Others have pointed this out too. Otherwise things like this will likely continue happening and package maintainers will overwhelming remain in the dark about what changes should be made in spec files. I recognize the work is difficult and time consuming. Again, this is my own opinion on how to approach the matter and however it is ultimately handled is fine with me. -- David Cantrell <dcantrell@xxxxxxxxxx> Red Hat, Inc. | Boston, MA | EST5EDT _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx