Thank you very much again for helping out here: I would not have known how to fix this. I am wondering if you think that it might be a good idea to ask upstream to update using openssl v 1.1 (with the patch included). If this is the future for openssl, then that might be a good move for them to use openssl 1.1?
I have also submitted updates to testing with this patch, thanks again!
From: Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx>
To: devel@xxxxxxxxxxxxxxxxxxxxxxx
Sent: Monday, September 11, 2017 9:11 AM
Subject: Re: ssl is not being compiled on dillo on F26
lör 2017-09-09 klockan 05:00 +0000 skrev Globe Trotter:
> Hi,
>
> Thank you for your detailed response. However, I tried replacing
>
> AC_CHECK_LIB(ssl, SSL_library_init, ssl_ok=yes, ssl_ok=no, -lcrypto)
>
> with
>
> AC_CHECK_LIB(ssl, SSL_writet, ssl_ok=yes, ssl_ok=no, -lcrypto)
>
> but I get the following error later on in the compilation:
>
> https.c: In function 'handle_certificate_problem':
> https.c:479:38: error: dereferencing pointer to incomplete type 'X509 {aka struct x509_st}'
> if ((cn = strstr(remote_cert->name, "/CN=")) == NULL) {
> ^~
> make[2]: *** [Makefile:887: https.o] Error 1
>
> I presume that this is an error on account of my change. How do I get around this error?
>
> Many thanks again!
With your change, the configure script detects openssl properly again.
However, you still need to do the necessary porting of the code itself
to support openssl 1.1. This is a different problem than getting
configure to work.
This is not the most obvious change, but you need to replace
remote_cert->name
with
X509_NAME_oneline(X509_get_subject_name(remote_cert)
Though the string returned by X509_NAME_oneline needs to be freed, so
just doing the replacement would result in a memory leak.
Patch attached.
Mattias
> Hi,
>
> Thank you for your detailed response. However, I tried replacing
>
> AC_CHECK_LIB(ssl, SSL_library_init, ssl_ok=yes, ssl_ok=no, -lcrypto)
>
> with
>
> AC_CHECK_LIB(ssl, SSL_writet, ssl_ok=yes, ssl_ok=no, -lcrypto)
>
> but I get the following error later on in the compilation:
>
> https.c: In function 'handle_certificate_problem':
> https.c:479:38: error: dereferencing pointer to incomplete type 'X509 {aka struct x509_st}'
> if ((cn = strstr(remote_cert->name, "/CN=")) == NULL) {
> ^~
> make[2]: *** [Makefile:887: https.o] Error 1
>
> I presume that this is an error on account of my change. How do I get around this error?
>
> Many thanks again!
With your change, the configure script detects openssl properly again.
However, you still need to do the necessary porting of the code itself
to support openssl 1.1. This is a different problem than getting
configure to work.
This is not the most obvious change, but you need to replace
remote_cert->name
with
X509_NAME_oneline(X509_get_subject_name(remote_cert)
Though the string returned by X509_NAME_oneline needs to be freed, so
just doing the replacement would result in a memory leak.
Patch attached.
Mattias
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
