Re: ssl is not being compiled on dillo on F26

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for your detailed response. However, I tried replacing

AC_CHECK_LIB(ssl, SSL_library_init, ssl_ok=yes, ssl_ok=no, -lcrypto)

with

AC_CHECK_LIB(ssl, SSL_writet, ssl_ok=yes, ssl_ok=no, -lcrypto)

but I get the following error later on in the compilation:

https.c: In function 'handle_certificate_problem':
https.c:479:38: error: dereferencing pointer to incomplete type 'X509 {aka struct x509_st}'
          if ((cn = strstr(remote_cert->name, "/CN=")) == NULL) {
                                      ^~
make[2]: *** [Makefile:887: https.o] Error 1

I presume that this is an error on account of my change. How do I get around this error?

Many thanks again!



From: Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx>
To: devel@xxxxxxxxxxxxxxxxxxxxxxx
Sent: Friday, September 8, 2017 2:31 AM
Subject: Re: ssl is not being compiled on dillo on F26

In openssl 1.1 some functions were renamed to newer more consistent
names. There are however preprocessor macros defined for most of them
so that old code still compiles. One of the old functions that was
renamed was SSL_library_init, which now is defined in
/usr/include/openssl/ssl.h as

# define SSL_library_init() OPENSSL_init_ssl(0, NULL)

The configure.ac in dillo uses AC_CHECK_LIB to detect the presence of
the openssl library like this:

AC_CHECK_LIB(ssl, SSL_library_init, ssl_ok=yes, ssl_ok=no, -lcrypto)

The AC_CHECK_LIB macro only checks for the presence of a symbol in the
library and bypasses any definitions in the header files, so it is
unaware of the preprocessor macro in the header file that redirects the
call to SSL_library_init to a call to OPENSSL_init_ssl. And since
SSL_library_init is no longer a proper symbol in the openssl library
the check fails.

This is easily fixed by replacing the check for SSL_library_init with a
check for a function that hasn't changed name, see e.g. the change
implemented in dcap:

https://github.com/dCache/dcap/pull/12/files

    Mattias
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx


_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux