On Wed, Jan 06, 2016 at 11:54:06AM +0000, Richard W.M. Jones wrote:
> On Tue, Jan 05, 2016 at 09:15:29PM +0200, Panu Matilainen wrote:
> > On 01/05/2016 07:16 PM, Richard W.M. Jones wrote:
> > >On Thu, Dec 24, 2015 at 03:01:02PM -0600, Jason L Tibbitts III wrote:
> > >>mingw-freetype (rjones, lfarkas, epienbro)
> > >
> > >This uses:
> > >
> > >%{!?_with_subpixel_rendering: %{!?_without_subpixel_rendering: %define _without_subpixel_rendering --without-subpixel_rendering}}
> > >
> > >_without_subpixel_rendering is not used anywhere else in the file.
> > >No idea if that is right or not.
> >
> > Another case where %define is actually wrong. The whole construct
> > looks like a workaround for %bcond related misunderstanding, but
> > dunno.
Actually in this second case, mingw-freetype.spec is just following
the freetype.spec file. Which also looks wrong because it defines
_without_subpixel_rendering which is never used anywhere.
http://pkgs.fedoraproject.org/cgit/rpms/freetype.git/tree/freetype.spec
Adding CC freetype-owner.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
