On 01/05/2016 07:16 PM, Richard W.M. Jones wrote:
On Thu, Dec 24, 2015 at 03:01:02PM -0600, Jason L Tibbitts III wrote:
coccinelle (rjones)
coccinelle.spec has:
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
TBH I have no idea if this is correct or not, or perhaps should be
completely removed. Thoughts?
That's one of those cases where using %define is actually *wrong*
because of the macro scoping thing. But in practise it'll never get used
since these days %python_sitelib is always defined so its not just wrong
but also pointless as well.
mingw-atk (rjones, epienbro, kalev)
Fixed.
mingw-freetype (rjones, lfarkas, epienbro)
This uses:
%{!?_with_subpixel_rendering: %{!?_without_subpixel_rendering: %define _without_subpixel_rendering --without-subpixel_rendering}}
_without_subpixel_rendering is not used anywhere else in the file.
No idea if that is right or not.
Another case where %define is actually wrong. The whole construct looks
like a workaround for %bcond related misunderstanding, but dunno.
- Panu -
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
