Re: Specs using %define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 24, 2015 at 03:01:02PM -0600, Jason L Tibbitts III wrote:
> coccinelle (rjones)

coccinelle.spec has:

%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}

TBH I have no idea if this is correct or not, or perhaps should be
completely removed.  Thoughts?

> mingw-atk (rjones, epienbro, kalev)

Fixed.

> mingw-freetype (rjones, lfarkas, epienbro)

This uses:

%{!?_with_subpixel_rendering: %{!?_without_subpixel_rendering: %define _without_subpixel_rendering --without-subpixel_rendering}}

_without_subpixel_rendering is not used anywhere else in the file.
No idea if that is right or not.

> mingw-gdk-pixbuf (epienbro, rjones, sailer)
> mingw-glib2 (fidencio, rjones, epienbro, lfarkas, sailer, kalev, elmarco)
> mingw-glibmm24 (sailer, elmarco, rjones)
> mingw-libgcrypt (rjones, epienbro)
> mingw-liboil (lfarkas, rjones)
> mingw-libsoup (epienbro, rjones)
> mingw-pangomm (sailer, rjones)
> mingw-pango (rjones, epienbro, kalev)

All done.

> mingw-libvirt (berrange, rjones, elmarco)

I didn't feel confident in changing this one.  I compared the
mingw-libvirt.spec file and ordinary libvirt.spec, and both use
%define extensively for with_* settings.  I assume there must be some
reason for that.

> nekovm (rjones, andyli)

Done.

> ocaml-ancient (rjones)
> ocamldsort (rjones)
> ocaml-omake (rjones)

Done.

> qemu (jforbes, dwmw2, berrange, quintela, ehabkost, amitshah, alon, rjones, bonzini, crobinso)

I was told off the last time I broke qemu.spec, so I didn't
modify this :-)  It uses %define 7 times.

> unison213 (rjones, gemi)
> unison227 (rjones, gemi, brummbq)
> unison240 (brummbq, rjones)

All done.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux