On Tue, Jan 05, 2016 at 09:15:29PM +0200, Panu Matilainen wrote:
> On 01/05/2016 07:16 PM, Richard W.M. Jones wrote:
> >On Thu, Dec 24, 2015 at 03:01:02PM -0600, Jason L Tibbitts III wrote:
> >>coccinelle (rjones)
> >
> >coccinelle.spec has:
> >
> >%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
> >
> >TBH I have no idea if this is correct or not, or perhaps should be
> >completely removed. Thoughts?
>
> That's one of those cases where using %define is actually *wrong*
> because of the macro scoping thing. But in practise it'll never get
> used since these days %python_sitelib is always defined so its not
> just wrong but also pointless as well.
>
> >>mingw-freetype (rjones, lfarkas, epienbro)
> >
> >This uses:
> >
> >%{!?_with_subpixel_rendering: %{!?_without_subpixel_rendering: %define _without_subpixel_rendering --without-subpixel_rendering}}
> >
> >_without_subpixel_rendering is not used anywhere else in the file.
> >No idea if that is right or not.
>
> Another case where %define is actually wrong. The whole construct
> looks like a workaround for %bcond related misunderstanding, but
> dunno.
Thanks Panu. I think I will delete both lines, and see if we
have any problems.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/devel@xxxxxxxxxxxxxxxxxxxxxxx
