On 21.02.2014 23:23, Kevin Kofler wrote:
Sandro Mani wrote:
This is what I have now [1].
[1] http://smani.fedorapeople.org/salome/salome-kernel-7.3.0/
The string "kernel module" in the summaries and descriptions is misleading.
(It can mislead users into thinking this is a module for the Linux kernel,
when actually this is just the core ("kernel") module of Salome.)
It currently fails installing with
[...]
DEBUG: CMake Error at idl/cmake_install.cmake:43 (FILE):
DEBUG: file problem creating directory:
/usr/lib/python2.7/site-packages/salome
DEBUG: Call Stack (most recent call first):
DEBUG: idl/cmake_install.cmake:60
(OMNIORB_COMPILE_IDL_FORPYTHON_ON_INSTALL)
DEBUG: cmake_install.cmake:67 (INCLUDE)
DEBUG: make: *** [install] Error 1
DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.XGlkzg (%install)
DEBUG: RPM build errors:
DEBUG: Bad exit status from /var/tmp/rpm-tmp.XGlkzg (%install)
DEBUG: Child return code was: 1
Also looking at your destdir patch, this is a new level of CMake abuse from
upstream, (ab)using EXECUTE_PROCESS to do stuff by hand rather than in
proper CMake targets (ADD_CUSTOM_COMMAND), and operating directly on the
installed path in the install phase. So yes, you need to add the DESTDIR
there by hand. EXECUTE_PROCESS is not meant to be used that way. (Instead,
they're supposed to compile their stuff in the
CMAKE_CURRENT_BINARY_DIRECTORY during the build, preferably using
ADD_CUSTOM_COMMAND rather than EXECUTE_PROCESS, and then just install the
already compiled file with INSTALL(TARGETS …), INSTALL(FILES …) or
INSTALL(PROGRAMS …), not INSTALL(CODE …).)
In any case, as a quick fix, you want to add the DESTDIR also here:
http://git.salome-platform.org/gitweb/?p=modules/kernel.git;a=blob;f=salome_adm/cmake_files/UseOmniORB.cmake;h=c0e4af6491d23b42e69b11f36089797200865b6c;hb=refs/heads/V7_main#l20
Thanks Kevin! I'll look at this tomorrow.
Sandro
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
