Enrico Scholz wrote:
Todd Zullinger <tmz@xxxxxxxxx> writes:Doing this would break current users that have already configured their system to use __git_ps1().What are "current users"? Those who installed your just released rawhide changes?
No, it breaks anyone that's currently using __git_ps1(), as the function was previously defined in /etc/bash_completion.d/git. Newer releases of bash-completion are moving to on-demand loading, hence upstream git has split out the __git_ps1() function and a few other support functions. Not having this available for current users means anyone with __git_ps1() in their prompt will get an ugly error every time they hit return, e.g.:
bash: __git_ps1: command not foundThat's far more annoying to far more people than having this function in the environment, in my opinion.
I don't see the compelling reason to jump through hoops or expect users to make more changes than needed to enable git info in their prompts. Without some justification of harm, I'm not inclined to change this. What's the reason to strongly oppose this being in /etc/profile.d?
If it's simply "I don't like these extra functions being defined", then I'm not persuaded, unless some massive amount of people have this same issue. I suspect that is not the case as anyone that has enabled bash completion until very recently would have many more functions defined by default.
Respectfully,
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A cynic is a man who, when he smells flowers, looks around for a
coffin.
-- H. L. Mencken
Attachment:
pgpJKIbNjm63E.pgp
Description: PGP signature
-- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
