Enrico Scholz wrote:
Todd Zullinger <tmz@xxxxxxxxx> writes:I placed git-prompt.sh in /etc/profile.d where it should be sourced for normal login shells.As I wrote in the update comment, please revert it. It pollutes the environment of every user with functions which are probably never be used.As these functions are useless without doing further modifications to ~/.bash_profile, it does not matter whether the user sources the script explicitly and modifies $PS1, or whether he modifies $PS1 only, or whether a script is sourced which modifies $PS1.Please move the script to /usr/share/git or to /etc/bash_completion.d where it can be requested by the user explicitly.
Doing this would break current users that have already configured their system to use __git_ps1(). I'm not inclined to agree that this "pollution" is a significant problem that warrants causing users to have to update their configuration.
I could be in the minority here. If so and we move it again, then we'd probably want to add a release note for f18 warning users that they will need to adjust their startup scripts.
Whatever we do, someone will be unhappy, that much I know.
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It's better to be wanted for murder that not to be wanted at all.
-- Marty Winch
Attachment:
pgpYSDAjHYuKA.pgp
Description: PGP signature
-- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
