On Sun, Jul 10, 2011 at 04:33:35PM -0400, Steve Clark wrote: > On 07/10/2011 01:49 PM, Matthew Garrett wrote: > >The suggestion isn't that having the options is wrong, it's that having > >them as the primary means of configuration is poor design. If your > >entire configuration takes the form of a shell script that constructs a > >set of command line options then you've increased fragility for no > >benefit. Having a proper configuration file and allowing admins to > >override specific aspects of that from the command line isn't a problem. > > > This is just your opinion - where in the else it this mantra preached. These scripts don't sanitise input beforehand. What happens if I'm logged in as root, change IFS and then do /etc/init.d/nfs restart? Using shell scripts for this is just a bad idea. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel