On Thu, 2010-07-22 at 04:25 +0200, Lennart Poettering wrote:
> On Thu, 22.07.10 12:06, Dave Airlie (airlied@xxxxxxxxxx) wrote:
>
> >
> >
> > >
> > > It is needed:
> > >
> > > if [ $1 -eq 1 ] ; then
> > > # For new installations, hook unit file into the appropriate places via symlinks
> > > /usr/bin/systemd-install enable --realize=reload %{unit name}.service > /dev/null 2>&1 || :
> > > else
> > > # For old installations, just reload the configuration, don't change symlinks
> > > /bin/bin/systemd-install realize --realize=reload %{unit name}.service > /dev/null 2>&1 || :
> > > fi
> >
> > Wow thats pretty special... both an option called realize and a
> > argument, that won't get confusing no matter how long it lives, also
> > realize doesn't seem to be conveying a useful meaning, I'm a native
> > speaker and I'm not sure what you actually mean by realize in this
> > context.
> >
> > I'm going with:
> >
> > to make real; give reality to (a hope, fear, plan, etc.).
> >
> > but its seems quite an abstract term to associate reality with an
> > abstract computer object.
>
> Well, I am not a native speaker. We were looking for a verb that
> basically means "make this take effect immediately".
>
> i.e. the "enable"/"disable" commands makes some changes for the next
> time they are looked at, and then adding --realize on top makes those
> changes take effect immediately, i.e. so that the unit is start/stopped
> according to those changes. We actually used "--start=" first (which
> however is very confusing when you'd write "disable --start" to disable
> something and then have it stop...) We then considered "--now", because
> it is not a verb. But eventually we stuck with --realize. It's not
> great, yes. But we couldnt think of anything better. Happy to take
> suggestions. But no, --take-effect-immediately is not really an option.
Why have two verbs in a command structure? isn't enable or disable the
order, --now seems like it would be correct, the thing with English is
its flexible about these sort of things.
Also you have --realize=reload and --realize=minimal, again
non-representative, minimal means reload if running, whereas reload
means start if not running otherwise reload? I would expect reload means
reload if running, otherwise do nothing, the other option would probably
be better specified as reload,start.
Dave.
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
