On 07/13/2010 04:59 PM, Till Maas wrote: > On Tue, Jul 13, 2010 at 03:55:46PM -0400, Luke Macken wrote: >> This patch looks good at a first glance -- it's pretty much exactly what >> I was planning to do. The only tweak that is needed is to ensure that >> anonymous people can't pretend to be AutoQA: >> >> - if comment.author == "autoqa": >> + if not comment.anonymous and comment.author == "autoqa": > > Yes, I thought about this later, too and forgot it again. But now I also > remembered a second issue. If autoqa uses -1 comments to indicate that > an update is not approved (anymore), then it must use +1 comments to > indicate that they are approved (again) to not influence the karma. Yep, good call. >> This patch, along with my critpath/nofrozenrawhide/epel changes, avoid >> making database schema changes to bodhi. This makes it very easy to >> perform upgrades. For the TurboGears2 port of bodhi that is underway, >> these flags should definitely be proper columns in the db model. >> Another benefit of the TG2 port is we will be able to utilize the >> SQLAlchemy migration tools, which will allow us to change the schema as >> we need to, instead of hacking together these "path of least resistance" >> changes. > > How long do think it will take till the TG2 port is ready? In the git > tg2 branch there has not been any activity since February. If it is a > very long term project, it might still be useful to keep the old bodhi > code cleaner for easier maintenance. I'd like to have it in beta testing phase by F14, but we'll see how that goes. The current tg2 branch has the entire model ported to SQLAlchemy, with a variety of improvements, and a lot of the test suite is ported over as well. The next step is to port the controllers & templates. I've been holding off on doing this for little while, as I have been doing a lot of bugfixing in the current branch, and I want to avoid having two out-of-sync code bases. However, we're pretty much at the point where I'm about ready to freeze the current branch and start porting the controllers over in the very near future. luke -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
