On Fri, 2019-05-31 at 11:43 -0600, Chris Murphy wrote: > On Fri, May 31, 2019 at 9:20 AM Adam Williamson > <adamwill@xxxxxxxxxxxxxxxxx> wrote: > > On Fri, 2019-05-31 at 13:44 +0200, Tomas Popela wrote: > > > > > > 2. Have we thought through all cases where the variant now being > > > > 'Workstation Live' rather than 'Workstation' might cause problems? > > > > > > > > > > What do you mean by that? Can you clarify it a little bit? > > > > Well, just look at the anaconda pull request: we change variant_name > > from "Workstation" to "Workstation Live" in fedora-silverblue.conf and > > the export of `ANACONDA_PRODUCTVARIANT` from "Workstation" to > > "Workstation Live" in liveinst. > > > > I am not sure of the consequence of these changes, but experience > > teaches me to be nervous any time some kind of significant string just > > ups and changes like that :) I don't know if that string winds up > > embedded somewhere in installed systems, for instance (and thus other > > things might be parsing it), or if other bits of anaconda may care > > about the variant name and haven't yet been changed... > > Do dnf or gnome-software upgrades use it? Updates I expect not, but > what determines what new things to include in an edition or product > and what things to remove? Package groups. So that wouldn't be a problem. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ desktop mailing list -- desktop@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to desktop-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/desktop@xxxxxxxxxxxxxxxxxxxxxxx
