On Fri, 2004-10-01 at 02:45 +0200, Matias Feliciano wrote: > Le ven 01/10/2004 à 01:40, Bastien Nocera a écrit : > > Hello Matias, <snip> > > Bug fixing isn't ripping out most parts of the code. system-config- > > soundcard expects a good kudzu. > > Since *you* tell me to not load modules, "my" new > system-config-soundcard don't use kudzu. What's that got to do with each other? > > By using only a "live" configuration, > > that means that we won't be able to configure cards for which a driver > > isn't loaded. > > As i understand, it's a job for kudzu/initscripts. Remember that you > tell me to not load module. Is system-config-soundcard touching /proc ? > No. > So I don't understand your point. It's a long time that modules are loaded on demand, and not force loaded by initscripts. > btw, kudzu (and your system-config-soundcard) don't load the sound > drivers when detecting hardware. kudzu load alsa and no more. > If currently "Play test" work it's only because there is a bug in alsa. > that let /dev/snd/controlC0 even if there is no driver. Well, that's a bug in ALSA, not something that should be worked around in a config tool. > "your" system-config-soundcard does not load modules of the other card. > And for the first card, you are lucky. Why am I lucky? I don't quite understand. > This why in my previous version I "modprobe" all drivers. Which isn't a job for the config tool. > > > > <snip> > > > > > And this is my following question for fedora-test-list : > > > > > Does system-config-soundcard have to continue to load all > > > > > modules whereas initscript/kmodule should do this job ? > > > > > > > > system-config-soundcard doesn't load the modules anymore, > > > > > > Fixed : > > > http://feliciano.matias.free.fr/system-config-soundcard/ > > > > > > > they're auto- > > > > loaded when the drivers are needed. > > > > > > With udev ? No. > > > > They should be. > > It's not autoloading module like we can do with a static /dev . > Rigth now, a module can be loaded even if we don't need it (read > rc.init). > btw, udev never load modules. > > > File a bug with udev. It isn't the job of the config- > > tool to load drivers on demand. > > > > > > Please, follow Jeff's advices if you want those bugs to be fixed soon. > > > > > > Seems too later for FC3. > > > To be honest, i don't want to split my patch. > > > This is too much work and ugly. > > > > + # Ugly > > > > And I'm not too interested in merging a patch with "Ugly" or "Hack" in > > the comments. > > The problem is the comment or the code ? > Sorry but your code is ugly and broken in many place even if you don't > have the honesty to state that in the comment. Most of the code actually isn't mine, I took over system-config- soundcard middle of August. > cat system-config-soundcard-1.2.10/src/*py | wc -l > 439 > cat system-config-soundcard-1.2.10.orig/src/*py | wc -l > 688 > > which one is ugly ? More code doesn't mean it's uglier. > > I'm sorry, but I still don't see what your patch is trying to achieve. > > http://www.redhat.com/archives/fedora-test-list/2004-September/msg01634.html > This url is in the previous message. Read and you see how *your* > system-config-soundcard is broken. "But I want ens1371 to be the first card. Mostly because OSS programs don't care about /etc/asound.conf." OSS will be removed in FC4. See the warnings in your kernel log every time an application uses OSS. > > You're ripping out 2.4 kernel support (this code I might still need for > > RHEL3), > > I request to do this here : > http://www.redhat.com/archives/fedora-devel-list/2004-September/msg01197.html > > No reply. I'm not on fedora-devel-list. > I state that i removed all old code here : > http://www.redhat.com/archives/fedora-test-list/2004-September/msg01634.html Same thing. > > removing kudzu usage and adding problems for people for whom the > > drivers aren't loaded > > What you want ? > First, i should not load module. > Next i should. No, you shouldn't load modules, and it won't work because you don't. > My previous version that I drop a few minutes ago...(RRRrrr), load > module with : > - kudzu : like you > - "modrobe -c" kudzu doesn't load the modules. kudzu gives the config tool a way to work on the real, hardware, configuration, instead of what modules are loaded. > My previous version do exactly what initscripts (rc.sysinit) does ! > Is your system-config-soundcard broken or initscripts ? > > > (relying on the OS configuration, rather than the > > system's one). > > Why not ? > With udev, all modules should be already loaded. If not, it's a bug. Then your code doesn't work with FC2... > > > > I'm interested in patches that would solve actual bugs, rather than > > rewrites and changes of directions made without asking the maintainer. > > First, the code is GPL. > Right ? Sure. But if you want the patches actually merged, you need the maintainer's approval. > Second : > http://www.redhat.com/archives/fedora-devel-list/2004-September/msg01197.html > > And I have post many messages in fedora-test-list stating that sound in > Fedora is broken. Yes, and we're dealing with bug reports one-by-one. Right now, the only big bug left is to unmute whenever we're loading this very config tool: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=132575 --- Bastien Nocera <hadess@xxxxxxxxxx> -- Fedora-config-list mailing list Fedora-config-list@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-config-list