Hello Matias,
On Fri, 2004-10-01 at 01:07 +0200, Matias Feliciano wrote:
> Le jeu 30/09/2004 à 09:33, Bastien Nocera a écrit :
> > Hello Matias, Jeff,
> >
> > On Thu, 2004-09-30 at 05:50 +0200, Matias Feliciano wrote:
> > > I don't know if it's a issue since Fedora (s-c-sc) doesn't support it
> > > anymore.
> >
> > Support for multiple soundcards was never in the code,
>
> Are you sure ?
> Don't understand.
That I added this support in the run to FC3, and that it never really
worked for OSS.
> > and that it even
> > unmutes the first card is a bit of magic, as there isn't any code to do
> > that in there.
> >
>
> What is that :
> amixer_path = "/usr/bin/amixer"
> amixer_pid = os.fork()
> amixer_args = [amixer_path, "-q", "sset", "Master", "75%", "on"]
Good point, missed that. I attached a patch for it unmuting the card for
which we're trying to play a sound.
> > > > so at least those 2 issues should be filed in 2 seperate reports.
> > > >
> > > > Also if you have enhanced the codebase
> > >
> > > No user visible enhancement (except bugfix).
Bug fixing isn't ripping out most parts of the code. system-config-
soundcard expects a good kudzu. By using only a "live" configuration,
that means that we won't be able to configure cards for which a driver
isn't loaded.
<snip>
> > > And this is my following question for fedora-test-list :
> > > Does system-config-soundcard have to continue to load all
> > > modules whereas initscript/kmodule should do this job ?
> >
> > system-config-soundcard doesn't load the modules anymore,
>
> Fixed :
> http://feliciano.matias.free.fr/system-config-soundcard/
>
> > they're auto-
> > loaded when the drivers are needed.
>
> With udev ? No.
They should be. File a bug with udev. It isn't the job of the config-
tool to load drivers on demand.
> > Please, follow Jeff's advices if you want those bugs to be fixed soon.
>
> Seems too later for FC3.
> To be honest, i don't want to split my patch.
> This is too much work and ugly.
+ # Ugly
And I'm not too interested in merging a patch with "Ugly" or "Hack" in
the comments.
Furthermore:
- self.apply()
+ self.mainWindow.destroy()
Your code won't work in the context of firstboot.
> soundcardBackend.py is the more modified file. Check this :
> wc -l system-config-soundcard-1.2.10.orig/src/soundcardBackend.py system-config-soundcard-1.2.10/src/soundcardBackend.py
> 298 system-config-soundcard-1.2.10.orig/src/soundcardBackend.py
> 138 system-config-soundcard-1.2.10/src/soundcardBackend.py
>
> diff -uN system-config-soundcard-1.2.10.orig/src/soundcardBackend.py system-config-soundcard-1.2.10/src/soundcardBackend.py | diffstat
> soundcardBackend.py | 300
> ++++++++++++----------------------------------------
> 1 files changed, 70 insertions(+), 230 deletions(-)
>
> How can I build independant patch for each bug ?
>
> btw, is it too hard to verify a 140 lines file ?
At 8 o'clock in the morning when I'm sipping my tea, yes.
$ gnomevfs-cat http://feliciano.matias.free.fr/system-config-
soundcard/system-config-soundcard-1.2.10-mat.patch | wc -l
645
I'm sorry, but I still don't see what your patch is trying to achieve.
You're ripping out 2.4 kernel support (this code I might still need for
RHEL3), removing kudzu usage and adding problems for people for whom the
drivers aren't loaded (relying on the OS configuration, rather than the
system's one).
I'm interested in patches that would solve actual bugs, rather than
rewrites and changes of directions made without asking the maintainer.
Sorry, but I will not commit your patch.
Cheers
---
Bastien Nocera <hadess@xxxxxxxxxx>
? unmute-right-card.patch
Index: soundcardBackend.py
===================================================================
RCS file: /usr/local/CVS/redhat-config-soundcard/src/soundcardBackend.py,v
retrieving revision 1.34
diff -u -r1.34 soundcardBackend.py
--- soundcardBackend.py 1 Aug 2004 18:23:28 -0000 1.34
+++ soundcardBackend.py 30 Sep 2004 23:14:01 -0000
@@ -107,7 +107,7 @@
return device, module, maker, model
def playTestSound(self, module, index):
- self.setVolume()
+ self.setVolume(index)
if kernel_type == '2.6':
if self.cardList == []:
@@ -218,8 +218,7 @@
retval = os.system("/sbin/modprobe -r %s" % module)
- def setVolume(self):
- #alsa drivers load muted. we need to set the volume for them.
+ def setVolume(self, index):
if kernel_type == '2.4':
aumix_path = "/bin/aumix-minimal"
aumix_pid = os.fork()
@@ -233,11 +232,13 @@
else:
os.waitpid(aumix_pid,0)
+ #alsa drivers load muted. we need to set the volume for them.
if kernel_type == '2.6':
+ device = "hw:%d"% index
amixer_path = "/usr/bin/amixer"
amixer_pid = os.fork()
- amixer_args = [amixer_path, "-q", "sset", "Master", "75%", "on"]
-
+ amixer_args = [amixer_path, "-q", "-c", device, "sset", "Master", "75%", "on"]
+
if (not amixer_pid):
try:
os.execv(amixer_path, amixer_args)
--
Fedora-config-list mailing list
Fedora-config-list@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-config-list