On Mon, Mar 03, 2025 at 04:48:36PM +0100, Philipp Stanner wrote: > On Tue, 2025-02-25 at 14:53 +0100, Danilo Krummrich wrote: > > On Tue, Feb 25, 2025 at 02:13:32PM +0100, Philipp Stanner wrote: > > > > - * is parked at which point it's safe. > > > + * drm_sched_cleanup_jobs. It will be reinserted > > > back after the > > > + * scheduler's workqueues are stopped at which > > > point it's safe. > > > > You don't know whether the workqueues are "stopped". I think you want > > to say > > that run_job / free_job work isn't scheduled or running. > > How about "after the scheduler's work items have been cancelled"? Sure, that's fine too. But be aware that you may have to change this wording in case another (unrelated) work item is gets added to the scheduler for some reason.
